Skip to content

[Debug] minor spelling fix #2107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SougandhS
Copy link
Contributor

No description provided.

Copy link
Contributor

github-actions bot commented Aug 6, 2025

Test Results

 1 947 files  ±0   1 947 suites  ±0   1h 35m 49s ⏱️ - 1m 52s
 4 720 tests ±0   4 696 ✅ ±0   24 💤 ±0  0 ❌ ±0 
14 160 runs  ±0  13 993 ✅ ±0  167 💤 ±0  0 ❌ ±0 

Results for commit 1fd2c51. ± Comparison against base commit 401d483.

♻️ This comment has been updated with latest results.

@laeubi
Copy link
Contributor

laeubi commented Aug 6, 2025

As it might be that the wrong attribute name is used in existing data, should at least reading the wrong name be used to recover such values?

@merks
Copy link
Contributor

merks commented Aug 6, 2025

Yes, of course this is used in a memento to serialize the value so all existing serializations will lose that value and that can't be a good thing.

@SougandhS
Copy link
Contributor Author

I can keep attribute value as misspelled and refactor variables name only

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants